I now have several trucks running the "in tank" unit..... we must have 200K on one of them after the change... . with no problems...
But on our 05 we had a pinched wire in the pump circuit that allowed winter chemicals to get into the wiring harness and caused a failure... . of course it was when I was with the wife and 5er...
$200 tow bill from the freeway(400 miles from home) and another $140 repair bill... but it was something that I just couldn't deal with on the edge of the freeway... .
While I waited for the tow truck I pulled my lap top out, pulled up the manual and did all the tests and ran it down to either a connection or a failed pump... . never considered the burnt wire from the chemicals. .
One of the tests was to turn the switch on, let it start to crank but not start the truck... (bump the starter) the pump than runs for 25 seconds... but there was no fuel in the filter and my wife couldn't hear the pump run... .
Of course the service writer wouldn't let me talk to the tech... . so I made him write into the computer my list of things done and my results. . and where I left off... . It didn't take the tech more than 10 min to find the problem... .
I personally think the "in tank" unit is a great fix... . and will run the life of the truck...