I think they do a good job, I have been a member for many years and they have always been the strongest voice defending the rights of American gun owners.
Unfortunately, they are handicapped by the very fact that they are indeed a member-driven organization. Like any other group, there are factions with different viewpoints, and a good amount of time and resources is spent squabbling. For the last few years, for example, there has been some vocal dissent with the "Winning Team" officer slate in general and Charlton Heston in particular. Many felt that Mr. Heston was not aggressive enough and that he didn't help our interests with comments about assault weapons.
I personally think Mr. Heston did an OUTSTANDING job. In a time when many celebrities are so afraid of the hugely liberal Hollywood power crowd that they won't even admit to owning guns, Mr. Heston stood up bravely and took a stand. He has been relentlessly villified for it by all his peers in Hollywood ever since. Think of this - how many people, even the aggressive TDR member types, are willing to stand up and PUBLICALLY defend a position that 95% of their peers oppose? Most folks won't even do that at a school board meeting, or in a meeting at work. Many times I have been to management meetings with 200+ supervisors being read the riot act by a VP, and have only 3-4 of us willing to speak up. I bet most of you have seen the same, so if you think about the personal risk to his career and safety that Mr. Heston took by standing up, you have to admit he has a lot of sand.
What people don't understand, even a fair % of the conservatives who read this board I wager, is that the 2nd Amendment is still in critical danger. The shooting sports are DYING in front of our very eyes and as the population of shooting enthusiasts dwindles, there will be fewer people defending the 2nd.
I can hear people right now, "How can you say that, Mike? My local sporting clays matches are packed to the brim. " Yeah, but look at the people who make up that crowd. Mostly older folks, still a few who have their kids involved but not many. The absence of KIDS ensures that the future is going to be very, very different.
Think of the things that have happened since the 1960's - we have gone from a country where just about everybody in the rural areas (and a lot from the cities) grew up shooting and learning about guns, to one where a child can be EXPELLED from his school simply for having a DRAWING OR PHOTO of a firearm! Where people under 18 are routinely treated like scum at gun shows and gun shops and not allowed to even TOUCH the firearms on display. Where Christmas catalogs no longer have BB guns and toy rifle sets to dream over. Where the only gun usage the average child ever sees is the rampant slaughter depicted in our entertainment media and criminal usage sensationalized on the tube every day. Where places to shoot have become harder and harder to find.
I think gun owners are responsible for a lot of that decline, not the NRA. We have sat meekly back and accepted "zero tolerance" laws at our schools, shuffled into the gun show eager to buy our new "gotta have it" and to busy to be concerned if kids are treated like 2nd class citizens, etc etc etc. One of the most damaging behaviors , in my humble opinion, is that people continue to patronize gun ranges and gun stores where the proprietors act like "Grumpy Old Men" and give kids and newcomers to the sport an experience that sours their attitudes toward guns and gun owners in general.
It isn't the NRA that isn't defending our rights - it's the guy next to you at the Cowboy Shooting match who won't write letters to his congressmen. It's the guys at my former (now closed) gun club who had no problem making concessions to the neighbors that closed down our indoor . 22 range, because after all they were still able to shoot trap and skeet so it didn't affect them. It's the guys who are happy to buy extremely powerful rifles for hunting purposes but who oppose magazine-fed semi-auto "assault rifles" (not even the correct term!) because they are ugly, unpopular, look menacing, nobody needs more than 5 rounds, etc etc freakin' etc. It's the people who think no one should be allowed to own handguns, and don't see a problem with any of the gun laws as long as it doesn't interfere with their ability to buy $10,000 Kreighoff shotguns or Palma match rifles.
The NRA is doing a pretty good job overall. The real question that gun owers should ask is: Are we?